Fix rsync errors and add CI#31
Merged
Carlosespicur merged 5 commits intorollingfrom Sep 18, 2025
Merged
Conversation
Carlosespicur
force-pushed
the
hotfix/fix-rsync-errors
branch
from
e023ea4 to
8dabbed
Compare
Carlosespicur
force-pushed
the
hotfix/fix-rsync-errors
branch
6 times, most recently
from
2c20fa6 to
f557331
Compare
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Carlosespicur
force-pushed
the
hotfix/fix-rsync-errors
branch
from
f557331 to
7c2367c
Compare
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
4ntn
reviewed
Sep 18, 2025
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
4ntn
approved these changes
Sep 18, 2025
Contributor
Author
|
@Mergifyio backport jazzy humble kilted |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654)
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654)
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654)
This was referenced Sep 18, 2025
Carlosespicur
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors and add CI (#31) * Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654) * Remove references to remote branches Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com> Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Carlosespicur
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors and add CI (#31) * Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654) * Remove references to remote branches Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use python 3.10 Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Force empy version Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com> Co-authored-by: Carlosespicur <carlosespicur@proton.me>
Carlosespicur
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix rsync errors and add CI (#31) * Fix rsync errors Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Add CI workflows Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Use correct branch on pull request runs Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Remove rsync installation from setup script Signed-off-by: Carlosespicur <carlosespicur@proton.me> * Review - Apply suggestions Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> (cherry picked from commit d516654) * Remove references to remote branches Signed-off-by: Carlosespicur <carlosespicur@proton.me> --------- Signed-off-by: Carlosespicur <carlosespicur@proton.me> Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com> Co-authored-by: Carlosespicur <carlosespicur@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes
generate_microros_library.sh. Some colcon packages don't follow the <package_name>/<package_name> directory schema to store the header files, sorsynccommand only runs if the directory exists.